I'm having trouble with this subroutine. It worked when the script was strictly procedural, but now that I'm trying to divide it into subroutines I get the error 
[Tue Jun 06 14:53:09 2006] [error] [client x.x.x.x] [Tue Jun  6 14:53:
+09 2006] bulkmailers-request.pl: Use of uninitialized value in concat
+enation (.) or string at /usr/lib/cgi-bin/bulkmailers-request.pl line
+ 56., referer: http://tangerine/cgi-bin/bulkmailers-request.pl
[Tue Jun 06 14:53:09 2006] [error] [client x.x.x.x] [Tue Jun  6 14:53:
+09 2006] bulkmailers-request.pl: readline() on unopened filehandle at
+ /usr/lib/cgi-bin/bulkmailers-request.pl line 57., referer: http://ta
+ngerine/cgi-bin/bulkmailers-request.pl

[download]
-the error msgs reference these lines 
$filename=~m/^.*(\\|\/)(.*)/; # strip the remote path and keep the fil
+ename
my ($newfilename) = $1;

open(LOCAL, ">/var/www/html/upload/".$newfilename);

[download]
sub process_form
{

my ($from_address) = $query->param('from');
my ($reply_to_address) = $query->param('reply_to');
my ($subject) = $query->param('subject');
my ($message) = $query->param('message');
my ($description) = $query->param('description');
my ($msg_month) = $query->param('msg_month');
my ($msg_day) = $query->param('msg_day');
my ($msg_year) = $query->param('msg_year');
my ($from_address2) = 'rjm@uchicago.edu';
my ($to_address) = 'rjm@uchicago.edu';
my ($mail_host) = 'smtp.uchicago.edu';

if ( validate_form (  $from_address, $reply_to_address, $subject, $mes
+sage, $description, $msg_month, $msg_day, $msg_year ) )
{

my ($filename) = $query->param('email_list');
$filename=~m/^.*(\\|\/)(.*)/; # strip the remote path and keep the fil
+ename
my ($newfilename) = $1;

open(LOCAL, ">/var/www/html/upload/".$newfilename);
while(<$filename>) {
    print LOCAL $_;
}

my ($mm) = new File::MMagic; # use internal magic file
my ($res) = $mm->checktype_contents("/var/www/html/upload/".$filename)
+;

# Adjust subject and body message
my ($message_body) = "Request submission\rFrom: ".$from_address."\rRep
+ly_to: ".$reply_to_address."\rSubject: ".$subject."\rMessage:\r\r".$m
+essage."\r\rRecipients: ".$description."\r\rDate message is to be sen
+t: ".$msg_month."/".$msg_day."/".$msg_year;  # Create the multipart c
+ontainer my ($msg) = MIME::Lite->new (   From => $from_address2,   To
+ => $to_address,   Subject => $subject,   Type =>'multipart/mixed' ) 
+or die "Error creating multipart container: $!\n";  # Add the text me
+ssage part $msg->attach (   Type => 'TEXT',   Data => $message_body )
+ or die "Error adding the text message part: $!\n";  # Add the file $
+msg->attach (    Type => $res,    Path => '/var/www/html/upload',    
+Filename => $filename,    Disposition => 'attachment' ) or die "Error
+ adding $filename: $!\n";  # Send the Message MIME::Lite->send('smtp'
+, $mail_host, Timeout=>60); $msg->send;  print $query->header; print 
+"<b>Thank you!</b><br>Confirmation of your submission will be emailed
+ to you.";  } }

[download]

In reply to uninitialized value in concatenation (.) by philosophia

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.