That depends (as always). The difference is, yours is "better" because it just does more. It makes sure to only do something if the environment variable has a proper value. If you "feel" you'd have to do something if the value is incorrect, like emitting a warning or an error, the if version is great. If you have built or validated your string beforehand, or got it out of a data store where only valid strings are, you can just use the assignment. If you're not sure that you'll remember what it does (because you're not using it very often, for example) just add a comment that explains it. When in doubt, I'd recommend your version though.

hth, p
Ordinary morality is for ordinary people. -- Aleister Crowley

In reply to Re^2: need help understanding perl syntax by phaylon
in thread need help understanding perl syntax by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.