Have a look at tachyon's Simple Module Tutorial for info on modules.

My take on this would be to put the CGI.pm query object in the 'common code' module too. That way you only have to 'use CGI;' once.

One way:

#!c:/Perl/bin/Perl.exe

use strict;
use warnings;

use MyCommon qw($q check_login common_footer);

my $log_in = check_login();

print $q->start_html(-title => 'log in');
print $q->p($log_in);
common_footer();
print $q->end_html;

[download]
MyCommon.pm would look like:

package MyCommon;

use strict;
use Exporter;
use CGI;

our (@ISA, @EXPORT_OK, $q);

@ISA = qw(Exporter);
@EXPORT_OK = qw($q check_login common_footer);

$q = CGI->new;

sub check_login {
  return "login ok";
}

sub common_footer {
  print $q->p('common footer');
}

1;

[download]

In reply to Re: Clarifications in subroutines, CGI.pm, HTML::Template and performance by wfsp
in thread Clarifications in subroutines, CGI.pm, HTML::Template and performance by sara2005

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.