I would say that it depends on how literally you take the word "always". e.g., If you've got a regex that is so simple as to need no explanation, I would say that including /x, but no internal whitespace/comments, is cargo cult because the /x has no effect. /m and /s are similarly pointless to include when dealing with data which is known to not contain newlines.

I'm always skeptical when I encounter the phrase "best practice". (In my experience, it tends to mean "We think this is the right thing to do, but can't be bothered (or aren't able) to explain why.") In this particular case, using /xsm with /(\d{3})-(\d{4})/ makes about as much sense as preferring $foo =~ /^bar$/xsm over $foo eq 'bar'. KISS. If you don't need the extra power/complexity, don't take special measures to make it available.

In reply to Re: Best practice or cargo cult? by dsheroh
in thread Best practice or cargo cult? by robinbowes

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.