You shouldn't have the %animal_sounds as a global variable in the main namespace (main:: or ::), but maybe have it as a global variable in the Animal:: namespace. You don't need the BEGIN blocks around your animal registration section, and you also don't break stricture.

Personally, I would use any of the Pluggable modules, like Module::Pluggable, especially when you want new plugins to become automatically discovered when they are available:

package Animal;
use Carp qw(croak);
use Module::Pluggable 
    require => 1,
    search_path => 'Animal', 
    sub_name => known_animals;

# use Memoize;
# memoize('known_animals');

my @known_animals = __PACKAGE__->known_animals;
my %animal_sounds;

for my $animal (@known_animals) {
    for my $sound ($animal->sounds) {
        croak "Ambigous sound '$sound' ($animal / $animal_sounds{$soun
+d})"
            if exists $animal_sounds{$sound};
        $animal_sounds{$sound} = $animal;
    };
};

# and in a separate file Animal/Dog.pm:
package Animal::Dog;
sub sounds { 'woof' };

[download]

In reply to Re: Factory Pattern by Corion
in thread Factory Pattern by tomazos

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.