Can anyone recommend any ways of cleaning this up? Is there a more elegant way of doing what I am trying to do? Without using BEGIN blocks and a global hash perhaps? Or without breaking any strictures?

What I'd do is let each animal declare what sound it made...

{   package Animal;
    use Carp qw( croak );    
    sub new { bless \my $scalar, shift };
}
{   package Sheep; use base 'Animal'; sub makes_sound { "baa"  } }
{   package Cow;   use base 'Animal'; sub makes_sound { "moo"  } }
{   package Pig;   use base 'Animal'; sub makes_sound { "oink" } }

[download]

then introspected the class hierarchy to find the animals that did what I wanted

use Devel::Symdump;
sub make_animal {
    my $sound = shift;
    my @animals_that_make_sound 
        = grep { eval { $_->isa( 'Animal' ) && $_->makes_sound eq $sou
+nd } }
            Devel::Symdump->rnew->packages;
    die "more than one animal can $sound\n" if @animals_that_make_soun
+d > 1;
    die "no animals $sound\n" unless @animals_that_make_sound;
    return $animals_that_make_sound[0]->new;
}

print make_animal( 'oink' );

[download]

In reply to Re: Factory Pattern by adrianh
in thread Factory Pattern by tomazos

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.