EvanK:

Mine still splits & loops. I made only small changes: 

#!/usr/bin/perl -w
use strict;
use warnings;

# returns error message on failure, undefined value on success
sub checkUPCrobot
{
  # grab and immediately split upc into array, 1 char per element
  my @chars = split(//, shift);

  # return error message if incorrect length
  if( $#chars != 11 )
  { return "should be 12 digits in length"; }

  # loop through to seperately sum even and odd chars
  my $odd=shift @chars;
  my $even=0;
  foreach (0..4)
  {
    $even += shift @chars;
    $odd += shift @chars;
  }

  # calculate correct check digit
  my $mult = ($odd * 3) + $even;
  my $check = 10 - ($mult%10);

  # return error message if wrong check digit was initially given
  if($check != shift @chars)
  { return "invalid checkdigit...should be $check"; }

  # otherwise, if validated, return undefined
  return;
}
#...snipped out the original checkUPC here to save space...
print &checkUPC("142687305632"), "\n";
print &checkUPCrobot("142687305632"), "\n";

[download]
I first got rid of the if even/odd in the first while loop by shifting the values off the array in pairs. I got rid of the second while loop by direct calculation.

UPDATE: I fiddled with it a little longer and came up with a slightly improved model:

# returns error message on failure, undefined value on success
sub checkUPCrobot2
{
  # grab and immediately split upc into array, 1 char per element
  my @chars = split //, shift;

  # return error message if incorrect length
  return "should be 12 digits in length" if $#chars != 11;

  my ($even, $odd, $check);
  foreach (0..5) {
    $odd += shift @chars;
    $check = shift @chars;
    $even += $check;
  }
  my $mult = 3*$odd+$even-$check;
  my $chk2 = 10 - ($mult%10);
  return "invalid checkdigit...should be $chk2" if $check!=$chk2;
}

[download]
--roboticus

In reply to Re: Summing the odd/even digits of a larger number (for upc check digits)...a better way? by roboticus
in thread Summing the odd/even digits of a larger number (for upc check digits)...a better way? by EvanK

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.