Are you looking for part of a string or the whole string? If you are looking for the whole string it is better to use eq because a regular expression is slower.

if ( $a eq 'abcdefgh' or $b eq 'abcdefgh' or $c eq 'abcdefgh') {

}

[download]

Also shorter code does not necessary mean it is easier to read. Taking your code and putting it into a tabular format,

if ( $a =~ /abcdefgh/ ||
     $b =~ /abcdefgh/ ||
     $c =~ /abcdefgh/ ||
     ....... ) {

}

[download]

One more thing, if you are trying to match the same pattern, put the pattern in a string and match against it. Name the pattern something that will make sense for the program can also enhance readability.

my $USER_NAME = qr{abcdefgh}xms;

if ($a =~ $USER_NAME ||
    $b =~ $USER_NAME ||
    $c =~ $USER_NAME) {

}

[download]

In reply to Re: howto make a very long IF statment shorter by Herkum
in thread howto make a very long IF statment shorter by jeanluca

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.