Fellow Monks

After asking a few question in the CB, about Uploading Files, I believe that the Correct snytax to use is

Anything in [] is pseudo code

$filename = [inputted field with Local Address, eg c:/file.jpg];
$file = [split of the filename removing everything before the last /]

open(OUTFILE,">>[destination].$file");
while ($bytesread=read($filename,$buffer,1024) ) {
  print OUTFILE $buffer;
}

$fh = upload('[name of field]');
while(<$fh>) {
  print;
}
[download]

Dont know why there is a print; but thats what the cpan doc says

My Question is this,
1. What do both Prints do
2. Does anyone have any suggestions to improve this code, and would it work

Update: The Long and short of it is, I want to upload any kind of file to a destiantion folder, similar in fashion to Photobucket, where you upload images to their site and link to them on things like forums

Solution

Here follows a copy of the working code

use CGI;
use CGI::Upload;

sub process {
  my $self = shift;
  my $q = $self->query;
  my $script = $q->script_name;

  my $filename = $q->param('uploaded_file');
  my $totalbytes;
  my ($bytesread, $buffer);
  my $numbytes = 1024;
  my $destination = "/home/[PATH REMOVED]/htdocs/uploads/";

#check rm

  print "Filename ($filename) good\n";
#sall good patch together
  my $output_file = $destination . $filename;

  print "Uploading $filename to $destination";
#upload time
  open (OUTFILE, ">", "$output_file")
    or die "Couldn't open $output_file for writing: $!";
  while ($bytesread = read($filename, $buffer, $numbytes)) {
    $totalbytes += $bytesread;
    print OUTFILE $buffer;
  }
  close OUTFILE;

#output
  print "sall good";

return;

}
[download]

Obviously the check rm is misising, all it will do is do the taint checks as described by Corion, ie check for actaully existance of the input, and check there are no illegal characters

Update

Minor glitch the code creates a file, but wont upload the contcnts of it, ie it creeats a file size of 0 bytes

Update

using

sub process {
  my $self = shift;
  my $html_template = $self->param('html_template');
  my $q = $self->query;
  my $script = $q->script_name;

  my $filename = $q->param('uploaded_file');
  my $from = $q->param('uploaded_file');
  my $diff_name = $q->param('diff_name');
  my $totalbytes;
  my ($bytesread, $buffer);
  my $num_bytes = 1024;
  my $destination = "/home/[PATH REMOVED]/htdocs/uploads/";

  binmode $filename; #just to be sure?

#check rm
  my ($results, $err_page) = $self->check_rm('input',
                                   {
                                     required => [qw/uploaded_file/],
                                     filters => ['trim'],
                                     msgs => {
                                               missing    => 'Please S
+upply a File Name',
                                             }
                                   });

  return $err_page if $err_page;

#sall good patch together
#  if ($diff_name)
#  {
#  $filename = $diff_name;
#  }
  my $output_file = $destination . $filename;
#upload time
  open (OUTFILE, ">", "$output_file") or die "Couldn't open $output_fi
+le for writing: $!";
  while ($bytesread = read($filename, $buffer, $num_bytes)) {
    $totalbytes += $bytesread;
    print OUTFILE $buffer;
  }
  die "Read Failure" unless defined($bytesread);
  unless (defined($totalbytes)) {
    print "<p>Error: Could not read file $filename, ";
    print "or was of zero length";
  } else {
    print "<p>Done ok, $totalbytes</p>";
  }
  close OUTFILE;
# or die "Couln't Close file $!";

#output
  my $output;

  $html_template->process('upload/form', {wrapper => $self->wrapper(),
                    status => "sall_good",
                    file => $filename,
                    dest => $destination,
                    from => $from,
                    }, \$output)
           || die $html_template->error;
  return $output;

}
[download]

Im getting the Read Failure error!

Specifically:

Getting a didnot return true value, and a read() on unopened filehandle then a Read Failure, it does gnerate the and empty file with the correct filename

Any Suggestions

Update

Im getting a Read Failure: Bad file descriptor

Suggestions?

The process doing the uploading is called lemons

#  open (OUTFILE, ">", "$output_file") or die "Couldn't open $output_f
+ile for writing: $!";
  open my $outfile, ">", $output_file or die "Couldn't open $output_fi
+le for writing: $!";
#  binmode $filename; #just to be sure?

  while ($bytesread = read($filename, $buffer, $num_bytes)) {
    $totalbytes += $bytesread;
    print OUTFILE $buffer;
  }
##  die 
print "Read Failure: $!" unless defined($bytesread);
[download]

num_bytes is 1024

filename is obtained from the form using a param

my $filename = $self->query->param('uploaded_file');

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.