Hi Monks,

I am having a file named one.txt,the contents are like,
This file is having data It is used for authentication Authentication number is 9
When I am running my script I get the new authentication no by @ARGV.If my new authenticaton is not equal to the authentication no found in the one.txt file,the new authentication number should be replaced inthe one.txt file.For this simple work I am using lot of lines.It looks bad for me.Let me know some other professional code to reduce my lines monks.The code is given below,
perl auth.pl 9 $argact = $ARGV[0]; open input,"one.txt"; open newfile,">output"; while(<input>){ if($_ =~ /^Authentication\s+number\s+is/){ @array = split(" ",$_); $fileid = (split(" ",$_))[3]; if($fileid ne $argact){ $changeflag = 1; pop(@array); push(@array,$argact); $newline = join(" ",@array); print newfile "$newline\n"; }else{ print newfile "$_"; } }else{ print newfile "$_"; } }
Thanks and Regards,
madtoperl.

In reply to File modification by madtoperl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.