Hi henka,

I hadn't used HTML::TokeParser::Simple before, but I just tried it now, and it works fine for me even after removing the second call: 

my $p = HTML::TokeParser::Simple->new($ARGV[0]);

[download]

So it seems logical that you would only instantiate the object once at the beginning.

(Update:  Whoops ... not necessarily the case, as several wiser monks have gently instructed below.)

A couple of points I'd mention, though.  First, if you add: 

use strict;
use warnings;

[download]

at the beginning of your code, you'll see that you've redefined $p.  (The strict and warnings pragmas are considered good programming practice, as they will catch a lot of things that might otherwise cause you problems -- it's a good idea to use them in all your programs).

Secondly, it might be more helpful to the user (or even yourself!) if you give an error message or a syntax message in case no argument are passed to the program.  For example: 

use HTML::TokeParser::Simple;
(my $url = shift) or die "syntax:  html_test  <filename>\n";
my $p = HTML::TokeParser::Simple->new($url);

[download]
s''(q.S:$/9=(T1';s;(..)(..);$..=substr+crypt($1,$2),2,3;eg;print$..$/

In reply to Re: More efficient use of HTML::TokeParser::Simple by liverpole
in thread More efficient use of HTML::TokeParser::Simple by henka

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.