(This continues from where philcrow and runrig left off.)

In

die("Cannot open weekly_${store}_pdf.sas to read from ")
   unless(open(FINAL, ">weekly_${store}_pdf.sas"));
[download]

• the error message is wrong ("read" vs "write"),
• the error message is grammatically incorrect (nothing follows the preposition "from"),
• the error message is incomplete (it doesn't state the reason for the failure),
• the file handle is not localized,
• package variables are used where lexical variables could be used,
• the 2 argument calling syntax of open is used rather than the safer 3 argument calling syntax, and
• the purpose of the statement (open) is hidden deep in the statement.

Fix:

open(my $fh_final, '>', "weekly_${store}_pdf.sas")
   or die("Unable to open weekly_${store}_pdf.sas for writing: $!\n");
[download]

Don't forget to replace the occurences of "FINAL" in the remainder of your code with "$fh_final".

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.