next if /^;/; #skip comments

[download]
It is complaining the xm switches are not included Change it to this,

Update: Also wrong per Jeronim

next if /^;/xms;

[download]
local $" = '|';

[download]
Don't use local variables, use my. Don't the special variables like $", use the English module.

Updated: Suggested but not working code

use English qw( -no_match_vars );

my $LIST_SEPERATOR = q{|};

[download]

Wrong spelling and yes will break your Code, Both pointed out by Jeronim and Chromatic...

use English qw( -no_match_vars );

{
local $LIST_SEPARATOR = q{|}; 
}

[download]

Would love to delete the post for just being wrong... Oh well :)

In reply to Re^2: Request for Perl::Critic Testimonials (some weirdnesses of the module) by Herkum
in thread Request for Perl::Critic Testimonials by jthalhammer

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.