Hi,

I picked up Spidering Hacks and I've had a problem with hack #19.

I keep getting the errors:

"my" variable @perlbooks masks earlier declaration in same scope at treebuilder.pl line 50.

Bareword "parent" not allowed while "strict subs" in use at treebuilder.pl line 15.

syntax error at treebuilder.pl line 34, near ")

Here is the script:

#!/usr/bin/perl
use strict;
use LWP::Simple;
use HTML::TreeBuilder;

my $url = 'http:www.oreilly.com/catalog/prindex.html';
my $page = get( $url ) or die $!;
my $p = HTML::TreeBuilder->new_from_content( $page );

my @links = $p->look_down(
    _tag => 'a',
        href => qr{^ \Qhttp://www.oreilly.com/catalog/\E \w+$}x
);

my @rows = map { $_->parent-parent } @links;

my @books;
for my $row (@rows) {
    my %book;
    my @cells = $row->look_down( _tag => 'td' );
    $book{title}  = $cells[0]->as_trimmed_text;
    $book{isbn}  = $cells[1]->as_trimmed_text;
    $book{price}  = $cells[2]->as_trimmed_text;
    $book{price} =~ s/^\$//;
    $book{url} = get_url( $cells[0] );
    $book{safari} = get_url( $cells[3] );
    $book{examples} = get_url( $cells[4] );
    push @books, \%book;
}

sub get_url {
    my $node = shift;
        my @hrefs = $node->look_down( _tag => 'a' )
        return unless @hrefs;
        my $url =  $hrefs[0]->attr('href');
        $url =~ s/\s+$//;
        return $url;
}

$p = $p->delete;

{
    my $count = 1;
        my @perlbooks = sort { $a->{price} <=> $b->{price} }
                grep { $_->{title} =~ /perl/i } @books;
        print $count++, "\t", $_->{price}, "\t", $_->{title} for @perl
+books;
}

{
    my @perlbooks = grep { $_->{title} =~ /perl/i } @books;
        my @javabooks = grep { $_->{title} =~ /java/i } @books;
        my $diff = @javabooks - @perlbooks;
        print "There are " .@perlbooks." Perl books and ".@javabooks.
              " Java books. $diff more java than Perl."
}
[download]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.