The first error liverpole identified is easy to find if you turn on warnings (which you are not using in your code):

[10] perl -Mwarnings /tmp/testit.pl
"my" variable @perlbooks masks earlier declaration in same scope at /t
+mp/testit.pl line 50.
Bareword "parent" not allowed while "strict subs" in use at /tmp/testi
+t.pl line 15.
syntax error at /tmp/testit.pl line 34, near ")
        return"
Global symbol "@hrefs" requires explicit package name at /tmp/testit.p
+l line 34.
Execution of /tmp/testit.pl aborted due to compilation errors.
[download]

The error stopping you from even compiling though, is the missing semicolon. 13 years of writing perl, and I still find missing semicolons, parens and braces are the hardest errors to find sometimes. I use perltidy now to try and help. For example, running your code through perltidy, I end up with:

sub get_url {
   my $node  = shift;
   my @hrefs = $node->look_down(_tag => 'a') return unless @hrefs;
   my $url   = $hrefs[0]->attr('href');
   $url =~ s/\s+$//;
   return $url;
}
[download]

Well, that long line jumped right out at me as being seriously wrong, and it was easy to figure out the fix then.

HTH,
~Jeff

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.