Here's how I would re-write that code:

use strict;
use warnings;

open my $name_fh, '<', 'name.txt'
    or die "Couldn't open name.txt.\n$!";

my $y = 0;

while ( <$name_fh> ) {

    chomp;
    next unless $_; # Skip empty filenames.

    my $name = $_ . '.txt';

    open my $out_fh, '>', $name
        or die "Couldn't open $name for output:\n$!";

    print $out_fh "Hello\n";

    $y++;

    close $out_fh
        or die "Couldn't close output file $name.\n$!";
}

close $name_fh; # Don't need to check for errors closing input files.

print "Created $y files.\n";

[download]

I've used lexical filehandles, avoided creating a list of filenames by simply dealing with the names one by one, checked for errors as needed. Note: I didn't validate the input. In other words, if your input file has garbage for filenames, you're going to get garbage filenames, or possibly illegal filenames. The only validation I've done is to skip empty filenames. Oh, and I also used strict and warnings as a best practice.


Dave

In reply to Re: creating a text file at run time and writing to it. by davido
in thread creating a text file at run time and writing to it. by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.