I'm wondering if you're complicating things a bit. Rather than count, and then loop, try simply looping. I have a suspicion that your cuts and pastes are changing the number of matches that //fig/label sees - once you've changed the first fig/label, it's no longer a fig/label. Try this: 

#!/usr/bin/perl

use strict;
use warnings;
use XML::Twig;

my $twig = new XML::Twig(
                         pretty_print => 'record_c'
                        );

$twig->parsefile('1.xml');

for my $fig (
             $twig->get_xpath('//fig')
            )
{
    my $label   = $fig->get_xpath('./label', 0);
    my $caption = $fig->get_xpath('./caption', 0);

    next unless $label and $caption;

    $label->cut();
    $label->paste('first_child', $caption);

}

$twig->print;

[download]
That seems to do the trick. Also note the better variable names ;-)

In reply to Re: XML::Twig 'cut' and 'paste' Question by Tanktalus
in thread XML::Twig 'cut' and 'paste' Question by prasadbabu

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.