There are many problems with this code, but here are your biggies:

• Don't construct your query string by hand. The POST method of HTTP::Request::Common does this for you. You simply supply it with an anonymous array in the form of [username=>$username, password=>$password, ...].
• If you do the above, you will not need your substitution statement.
• The || operator is a high-precedence operator. See perlop for the details, but in short, the || in the "fail 1" line evaluates before the comma operator does. In fact, the only reason your code does not print "fail 1" is because || short-circuits on the "true" evaluation of $formurl.
• In general, what you're trying to do is actually much easier than you are making it out to be. Here is one way it can be done:

  use LWP::UserAgent;
  use HTTP::Request::Common;
  
  my $formurl  = "http://www.amihotornot.com/board.pl";
  my $id       = 20010131;
  my $username = "MeowChow";
  my $password = "catfood";
  my $subject  = "Fancy Feast is neither fancy nor a feast.";
  my $post     = "Discuss amongst yourselves...";
  
  # construct an anonymous array for the Http::Request::Common::POST met
  +hod
  my $formvars = [
    id        => $id,
    username  => $username,
    password  => $password.
    subject   => $subject,
    comments  => $post,
    submit    => "Submit",
  ];
    
  $ua = new LWP::UserAgent;
  $ua->request(POST $formurl, $formvars);
  [download]

• Read the HTTP::Request::Common documentation, specifically the part about POST.

   MeowChow                                               
                print $/='"',(`$^X\144oc $^X\146aq1`)[-2]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.