I cannot help feeling there is a better way of doing things, which will make better use of the computer's resources.

Any improvement on the OP would be a matter of robustness (along the lines suggested by GrandFather), or of "standardizing" on a solution that is already available (i.e. using a CPAN module), or merely of style or perceived maintainability (e.g. using fewer lines of Perl code and/or adding commentary/POD to describe the expected input file format, etc).

All of those are possible, but none of them have any impact that I could imagine on "making better use of the computer's resources". I'm not really sure what you mean by that, but if you mean "make the process more efficient", I don't think any change of the OP code would have noticeable impact -- what you've posted is close enough to being as efficient as possible.

If there is some other aspect to "use of the computer's resources" that you're thinking of, that might make an interesting discussion.

BTW, I think, given the sample file contents, your use of  $date{$array[1]} = $array[2] would be wrong; the indexes should be 0 and 1 instead. Or better yet, something like this:

open INPUT, "<", $InputFile; my %data = map { chomp; split( /:/, $_, 2 ) } <INPUT>; close INPUT;

That's really minimalist -- maybe a bit too much so for some, but it's really a matter of taste and how much you can trust your data files to be as expected.

(Updated the split so that it returns at most two elements per line from the input file; this is still vulnerable to serious trouble if the file contains any sort of line that lacks a colon.)


In reply to Re: Converting a Flat-File to a Hash by graff
in thread Converting a Flat-File to a Hash by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.