my $out = ">./coffee.tmp";

[download]
Does your file name have a '>' character in it? You should probably be using the three argument form of open instead. 

open OUT, $out || die "Can't open $out!\n";
open FILE, $file || die "Can't open file oldcoffee!\n";
close FILE, $file || die "Can't close file oldcoffee!\n";
close OUT, $out || die "Can't close $out!\n";

[download]
Using the high precedence || operator means that the dies are superfluous. You should use the low precedence or operator instead. close accepts one argument, the filehandle. You should also include the $! variable in the error messages so you know why the program failed. 

    $mails[$#mails + 1] = $_;

[download]
Is better written as: 
    push @mails, $_;

[download]
If you want to split the mbox file into separate files based on the year in the /^From/ line then you probably want something like this: 

#!/usr/bin/perl
use warnings;
use strict;

my $file = 'oldcoffee.tmp';
my $out  = 'coffee.tmp';

open FILE, '<', $file or die "Can't open file $file! $!\n";

while ( <FILE> ) {
    if ( /^From / && /(\d{4})$/ ) {
        # Update: changed 'readonly' to 'append'
        open OUT, '>>', "$1$out" or die "Can't open $1$out! $!\n";
    }
    fileno OUT and print OUT;
}

close FILE or die "Can't close file $file! $!\n";

__END__

[download]

In reply to Re: Spliting an mbox file by jwkrahn
in thread Spliting an mbox file by monger

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.