my $max1;
   my $max2;
   my $min1;
   my $min2;
   my $i;

[download]
These, and others are all used uninitialized. That is what strict has been trying to tell you. 
my ($max1, $max2, $min1, $min2, $i) = (0,0,0,0,0, );

[download]
Would be better but if I see variable names like that ( $x1, $x2 ) then I think something is wrong with the program structure. In this case the author has not used subroutines to factor out duplicate code so he resorted to overlapping variable names and cluttered up the namespace.

    open(FILE1,"fwd.stb"); should be:     open(FILE1,"fwd.stb") or die "Can\'t open file\n";

The same errors are repeated later in the code because the same code is repeated. Use subroutines to replace repeated code. At least you won't have to fix every error twice.

   for($i=0;$i<$len-1;$i++)This will skip the last element of the array. The conditional should be <= or a more perlish: for(0 .. scalar @x -1)

You have two variables $call and $count that are neither declared nor initialized. Strict has been trying to tell you that also.

s//----->\t/;$~="JAPH";s//\r<$~~/;{s|~$~-|-~$~|||s |-$~~|$~~-|||s,<$~~,<~$~,,s,~$~>,$~~>,, $|=1,select$,,$,,$,,1e-1;print;redo}

In reply to Re: Prob with 'while' loop and subroutine calling by starbolin
in thread Prob with 'while' loop and subroutine calling by cool

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.