I didn't like like a number of points of style in your code,
so I fiddled with it. There are more changes than I feel
like listing, but you can tell what they are yourself. So
I'll just show my changed (not necessarily improved) version
and you can decide if it's an (?:dis)?improvement.
#!perl -w
use strict;
unless (@ARGV==2) {
die <<EOF;
$0 strips comment lines beginning with # from perl code
usage: $0 infile outfile
set outfile to \"display\" to just show result
EOF
}
my $infile = shift;
my $outfile = shift;
my $full_code = '';
my $bad_lines = 0;
my $good_lines = 0;
open(IN,"< $infile") or die "Can't open $infile: $!\n";
while (<IN>) {
if ( /^\s*#[^!]/ ) { # if comment line
$bad_lines++;
}
else {
$good_lines++;
$full_code .= $_; # add to code
}
}
close(IN) or die "Can't close $infile: $!\n";
if ($outfile eq 'display') {
print $full_code;
}
else {
open(OUT,"> $outfile") or die "Can't write to $outfile: $!\n";
print OUT $full_code;
close(OUT) or die "Can't close $outfile: $!";
}
print ($good_lines+$bad_lines) . "lines read from $infile\n",
"$bad_lines comment lines detected in $infile\n",
"$good_lines lines written to $outfile\n";
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.