Thanks for the lesson repson. I see the wisdom of your changes:

• replaced multiple print statements with here docs
• eliminated useless scalar use
• replaced the hash with string concatenation via assignment op
• one while instead of for loops, sorting and subroutine
• more elegant flow eliminates need for multiple exits

But the final print statement:

print ($good_lines+$bad_lines) . "lines read from $infile\n",
            "$bad_lines comment lines detected in $infile\n",
            "$good_lines lines written to $outfile\n";
[download]

Failed on 5.00503 with the warning:

print (...) interpreted as function at unc_rep.pl line 40.
[download]

So /me sweeps up around the monastery:

my$lines=($good_lines+$bad_lines);
print "$lines lines read from $infile\n",
      "$bad_lines comment lines detected in $infile\n",
      "$good_lines lines written to $outfile\n";
[download]

ps - fixed omission of the 2nd $0 in the original.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.