my creates a variable in an empty state. Assigning emptiness to an empty container is redundant.# Define our buckets for collecting data my %bucket = (); my %USER = (); my %VIRUS = (); my %SPAM = ();
It would be more efficient to use a hash instead of an array there.# These numbers must be valid reason codes... my @wanted = ( 1, 60 );
A for loop iterates over a list which means that the entire contents of the file have to be stored in a list in memory before it can be iterated over. It is more efficient to use a while loop which only reads one line at a time.for (<$file>)
while ( <$file> )
The chomp is superfluous because split /\s+/ removes all whitespace. You are declaring eleven variables but you are only using three. You can use undef as a placeholder:chomp; my ( $month, $day, $time, $host, $process, $clientIP, $MessageID, $timeStart, $timeEnd, $service, @INFO ) = split /\s+/;
my ( undef, undef, undef, $host, undef, undef, undef, undef, undef, $s +ervice, @INFO ) = split;
If you had used a hash for wanted then you would not need to use grep.$USER{$host}{$recip}{$action{$service}{$action_}}{$reason{$rea +son_}}{'count'}++; #if ( grep /^$reason_$/, @wanted );
$USER{$host}{$recip}{$action{$service}{$action_}}{$reason{$rea +son_}}{'count'}++; #if exists $wanted{ $reason_ };
In reply to Re: spamstats.pl
by jwkrahn
in thread spamstats.pl
by tcf03
| For: | Use: | ||
| & | & | ||
| < | < | ||
| > | > | ||
| [ | [ | ||
| ] | ] |