There are a couple of things that can be improved with your code. I will not address all of them ...
- Instead of the goto you want subroutines (perlsub).
- Don't use global variables if they can be avoided.
- Comparisons like $foo eq ('baz' || 'bar') don't work, use $foo eq 'baz' || $foo eq 'bar' instead.
- Please consider indenting your code properly, e.g. like perltidy does it.
- use warnings; can help you uncover bugs in your code.
To get a bit more concrete, here are some bits and pieces of your code rewritten:
open TESTCASE, "imp2.txt" or die $!;
chomp(@array = <TESTCASE>);
open CONFIGFILE, "imp1.txt" or die $!;
and instead of the
goto OUTER (a similar improvement can be made for
goto INNER):
if (...)
{
$incr++;
sendMessage();
}
# ...
{
my $msg = <<END;
REGISTER sip: 36.212.176.07 SIP/2.0\r
Via: SIP/2.0/UDP 36.212.176.90:5060; branch= z9hg4bk340\r
...
END
sub sendMessage
{
print "\nSending message:$msg";
$MySocket->send($msg);
}
}
-- Hofmator
Code written by Hofmator and posted on PerlMonks is public domain. It is provided as is with no warranties, express or implied, of any kind. Posted code may not have been tested. Use of posted code is at your own risk.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.