OverlordQ,
When you discussed this in the CB earlier, I was too busy thinking of my own solution to listen to what
tye and
ambrus had to say. I believe they felt an O(N) solution was possible. I believe this is an improvement on your code but doubt it is as efficient as what they had in mind.
#!/usr/bin/perl
use strict;
use warnings;
use List::Util 'sum';
my @set = (3, 2, 8, 9, -25, 5, 8, 4, 4, -3, 5, 3, -10);
pop @set while $set[-1] < 0;
shift @set while $set[0] < 0;
my @neg = map {$set[$_] < 0 ? $_ : () } 0 .. $#set;
my @beg = (0, map {$_ + 1} @neg);
my @end = ($#set, map {$_ - 1} @neg);
my ($beg, $end, $max, $sum) = (0) x 4;
for my $i (@beg) {
for my $j (@end) {
next if $j < $i;
$sum = sum(@set[$i .. $j]);
($beg, $end, $max) = ($i, $j, $sum) if $sum > $max;
}
}
# Adjust accordingly if leading/trailing negatives
print "$beg .. $end = $max\n";
Since this is a homework assignment, I have not provided comments, but I will do so in the future for others that may come across this thread. Improvements are possible but hopefully different algorithms will be presented by others.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.