( Note: I assumed
$total_nums contains an integer or that your code was mishandling 30.5 and the like.
)
If you invert the order of the checks, you can simplify to the following.
$test_nums = $total_nums > 180 ? $test_nums
: $total_nums > 150 ? 6
: $total_nums > 120 ? 5
: $total_nums > 90 ? 4
: $total_nums > 60 ? 3
: $total_nums > 30 ? 2
: 1;
Since the breakpoints form continuous serious of multiples of 30, the above could be simplified further using a loop. Or better yet, using division.
if ( $total_nums <= 0 ) {
$test_nums = 1;
} elsif ( $total_nums <= 180 ) {
$test_nums = int( ( $total_nums - 1 ) / 30 ) + 1;
}
Update: I got sidetracked while writting my reply, so other people have posted similar solutions already. Please excuse any duplication.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.