0:13:46:b:4:31 ^^ First pass ^^^^ Second pass ^^^ Third pass

You're expecting the regexp to match the same : twice. Use a zero-width lookahead to check for the trailing : or end of string.

$mac =~ s/(^|:)([0-9a-fA-F])(?=:|$)/${1}0$2/g;

Better yet, eliminate needless copying.

$mac =~ s/(^|:)(?=[0-9a-fA-F](?::|$))/${1}0/g;

Update: Tested. Fixed bug where : would get removed.

Update: If you really need speed, the following is much faster, but it sacrifices readability:

$mac =~ s/(?<=:)(?=[0-9a-fA-F](?::|$))/0/g; $mac =~ s/^(?=[0-9a-fA-F](?::|$))/0/;
Rate orig fast orig 36251/s -- -42% fast 62533/s 72% --

In reply to Re: Regex overlap in MAC address by ikegami
in thread Regex overlap in MAC address by superfrink

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.