comment on

Gee, it's actually not the worst Perl code I have seen by any stretch of the imagination. A couple of points:

the else is easier to see if it is not cuddled:
```
rather than this:

} else {

use this:

}
else {
[download]
```
which then gives the braces the same relative position fo the if and the else.
Carefully consider NOT using the unless it can be quite counter-intutitive when reading code.

This:

unless ( scalar(@downhosts) == 0 ) {
    print p, "There $verbage[2] ", scalar(@downhosts), "  $verbage[3] 
+unreachable\n", br;
    }

rather than:

unless ( scalar(@downhosts) == 0 ) { print p, "There $verbage[2] ", sc
+alar(@downhosts), "  $verbage[3] unreachable\n", br }
[download]

CGI

And finally, use perltidy. I have it in the toolbox in my Komodo so I can run it over my code any time. It actually mkes it easier to spot problems when I can see thngs like the indentation level go wrong! It also gives me a consistency of style I am too lazy to get any other way.

jdtoronto

In reply to Re: improving the aesthetics of perl code by jdtoronto
in thread improving the aesthetics of perl code by tcf03

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

For: Use:

& &

< <

> >

[ [

] ]
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`