Hi. I'm more or less new to perl, and while this code is functional and it does what I want it to do...my question is, is this the "best" way? Are there some additional caveats and/or shortcuts I could be using here?
my $srcdir = '/var/local/some_dir/';
my $mtime = '1';
my $destdir = '/backup/some_dir/';
unless (-d $srcdir && -d $destdir ) {die "Error: $!";}
print "Beginning backup...\n";
chdir $srcdir;
opendir(INDIR,$srcdir) || die "Can't open directory: $!";
my @files = readdir(INDIR);
closedir (INDIR);
foreach (@files) {
unless (-d || $_ eq "." || $_ eq "..") {
if (-M > $mtime) {
print "$_ : Older than one day.\n";
} else {
`tar -cz $_ -f $_.tar.gz`;
`mv *.gz $destdir`;
print "$_ archived in $destdir\n";
}
}
}
Many thanks in advance.
2006-09-30 Retitled by planetscape, as per Monastery guidelines: one-word (or module-only) titles hinder site navigation
( keep:1 edit:22 reap:0 )
Original title: 'Elegance?'
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.