Some comments:

unless (-d $srcdir && -d $destdir )

It's better not to use unless, unless for simple conditionals ;^).


opendir(INDIR,$srcdir) || die

Better use lexical filehandles. Also, I don't like to use parentheses, it makes the code more perlish:

opendir my $indir, $srcdir or die "blah: $!";

unless (-d || $_ eq "." || $_ eq "..") {

Same as above. Quick, what does this do?

unless ($bar =~ /bar/ or $baz !~ /qux/ and defined $undef)

`tar -cz $_ -f $_.tar.gz`;

Use backticks when you are going to use the output of the command. This is not the case, so you better use system.

Update: Oh, there's a recent thread about unless, be sure to check it out.

--
David Serrano

In reply to Re: Is this the most elegant way to code directory lookup? by Hue-Bond
in thread Is this the most elegant way to code directory lookup? by texasperl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.