You have two a syntax mistake s in your foreach .
UPDATE: ysth is correct about the chomp. It was uneeded as my code was orginally posted

sub total {
 my $number;

 foreach (@_) {
  # you are allowing input from STDIN which is going to
  # add a \n on the end. So you're going to have to add
  # a chomp
  chomp;  # UPDATE: ysth is correct, but I'll leave it in
          # for the next line I added 
  next if (!/^[+-]?[[:digit:].]+$/); # UPDATE: This is slightly better

  # $number += @_[$_];
  # $_ is assigned the value of the element in @_ not the index
  # So you want
  $number += $_;
  
 }

 return $number;
}

my @fred = qw{ 1 3 5 7 9 };
my $fred_total = &total(@fred);  # & not required
print "The total of \@fred is $fred_total.\n";
print "Enter some numbers on separate lines: \n";
my $user_total = &total(<STDIN>);
print "The total of those numbers is $user_total.\n\n";
[download]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.