Your program has a couple of problems:

First, you are splitting on comma's, then the pc no (the first field) has index 0, index 1 gets you the ip-address.

Next, you are reading the entire second file for each line found in the first file, that will give you some serious I/O for big files.

Perl is not very good at finding out whether something is in a list. If you want to do that, think of a hash in stead. Lists are for processing bulk data element by element. Keeping this in mind, let's rewrite the program.

Assuming you have two files, pcs_old.csv and pcs_new.csv, starting with the opening stuff: 

use strict;
use warnings;
open (OLD, "<pcs_old.csv");
open (NEW, "<pcs_new.csv");

my %old; # where pc numbers will get stored...

[download]
Read the old file line by line... 
while (<OLD>) {
   chomp;
   my @fields = split /,/;
   my $pc = $fields[0];   # get the first field
   $pc =~ s/"//g;         # get rid of the quotes
   $old {$pc} = 1;        # make an entry in the hash
}

[download]
Now do the same for the new pc file, but instead of storing them, see if an entry exists in the database with old pc's: 
while (<OLD>) {
   chomp;
   my @fields = split /,/;
   my $pc = $fields[0];   # get the first field
   $pc =~ s/"//g;         # get rid of the quotes
   if (! exists $old {$pc}) {
      # the new pc file has a pc which did not exist
      # in the old pc file
      print "new PC found: $pc\n";
   }
}
# and cleanup
close (OLD);
close (NEW);

[download]

In reply to Re: Comparing two files by lyklev
in thread Comparing two files by Ronnie

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.