I have a subroutine that gets a web page using LWP::UserAgent. If the page returns an error I sleep for 100 seconds and try again.

Right now I use REDO in a named block to submit the page again, and I believe this might be looked upon as a poor implementation. What would be a better way to do this?

Here is my solution:
sub get_html {

  my %form;
  my $page;

  #  Get ID
  ( $form{id}, $page ) = @_;

  my $data;
  get_page: {
    #  Get web page
    my $response = $ua->post( $page, \%form );

    #  Check for errors
    if ($response->is_success) {
      $data = $response->content;
    } else {
      sleep 100;
      redo get_page;
    }
  }

  return \$data;
}

[download]

In reply to Using REDO in Subroutine, need better way? by awohld

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.