while (($key, $value) = each %hash) {

[download]

You got three things wrong:

  1. use while, not foreach
  2. the pair returned by each is $key,$value not $value,$key
  3. you need parentheses around ($key,$value)

But of course, if he wants to use foreach, then for completeness it's fair to remind that he can do so, but in connection with keys, not each:

foreach my $key (keys %hash) {
    my $value=$hash{$key};

[download]

Update: hadn't noticed it already been covered by imp's reply. Hopefully repetita iuvant

In reply to Re^2: Using foreach to process a hash by blazar
in thread Using foreach to process a hash by iridius

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.