Update: this node has been changed from it's original post, it has been posted to try to answer the question

hmm, how about something like:

my $pattern = shift;

#get the lines you're looking for in the file
open HIST, "$HOME/.bash_history" or die "Couldn't open history file: $
+!\n";
my @list = grep { /$pattern/ and chomp and $_ } <HIST>;
close HIST;

#ask and run the commands
foreach my $com (@list) {
   print "run [$com] (y/n)? ";
   my $ans = <STDIN>;
   $ans =~ /^y/i    && do {
       my $result = `$com`;
       # error checking here
       print "result: $result\n";
   };
}

[download]
The only major difference is that most everything is kept in perl which allows for more error checking (like dying if the file doesn't exist or can't open, which you could check anyway, but hey =).

There really isn't much difference between the two, but i think you typoed on the binding operator ($choice eq 'Y' is fine, but $choice =~ 'Y' doesn't make much sense).

HTH,
jynx

In reply to Re: command recall by jynx
in thread command recall by Kickstart

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.