As jesuashok points out, in order to assign an anonymous array as the value of  $spr_hash{$file_name} you have to put curlies around that, and put the "@" outside the open-curly. (You don't need to assign an empty array reference to it first.)

I think you also need to include the path with the file name when doing the "-d" test, unless that path happens to be the current working directory when you run the script. (I'm assuming the directory you're reading could contain subdirectories.)

Apart from that, why do you cast the hash into an anonymous array when passing it to Data::Dumper? (Just curious -- normally, I'd expect something like print Dumper( \%hash ); .)

Did you consider slurping the file, to simplify the structure? (You can always do "split /\n/" as needed later on.)

And don't you hate having to put in long string literals more than once? I do -- so much so that it's worth declaring another scalar:

my %spr_hash; # you do use strict, don't you? my $path = "/apps/inst1/metrica/TechnologyPacks/ON-SITE/Nokia_S11.5/re +portspr"; opendir( D, $path ) or die "$path: $!"; while ( my $file = readdir( D )) { next if ( -d "$path/$file" ); open( F, "<", "$path/$file" ) or die "$path/$file: $!"; # @{$spr_hash{$file}} = <F>; # I'd rather slurp to a scalar: { local $/; $spr_hash{file} = <F>; } } print Dumper( \%spr_hash );

In reply to Re: building a hash with filname and itscontents by graff
in thread building a hash with filname and itscontents by greatshots

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.