grep() won't do anything bad to @_, but I am personally against doing two operations in a row like you did that are complements.

That being said, I'd rewrite the @_-filtering line as: 
my %args;
push @{ $args{ref($_) eq 'HASH' ? 'opt' : 'ext'} }, $_
  for @_;

[download]
Or, I might even do a moving-splice() trick: 
sub import {
  my $self = shift;
  my ($i,$j,@options);

  for (@_) {
    if (++$j, ref($_) eq 'HASH') {
      push @options, splice(@_, $j + --$i, 1);
      $_ = $_[$j+$i], redo if $j + $i < @_;
    }
  }

  # handle @options
  # @_ now only holds elements which aren't hash refs

  $self->SUPER::import(@_);
}

[download]
</code>

japhy -- Perl and Regex Hacker

In reply to Re: An alternate way of implementing import with options by japhy
in thread Passing parameters to a module's import function by rrwo

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.