Straightforwardness in code is a virtue.

While you can shoehorn sort into doing this, it will not be as clear as a more straightforward algorithm. Furthermore should your requirements change (eg some dataset unexpectedly has a circular dependency and your code needs to detect that), it will be easier to make that change with a more straightforward solution. Something like this:

sub rank_objects { my @objects = @_; my $n = 0; my @next_objects = grep {not $_->depends_on} @objects; my @current_objects; while (@next_objects and $n < @objects) { $n++; @current_objects = @next_objects; @next_objects = (); for my $object (@current_objects) { $object->set_rank($n); push @next_objects, $object->depended_on_by; } } my @circular = @next_objects, grep {not $_->rank} @objects; if (@circular) { # We have circular dependencies, report that somehow. # In production code I'd actually try to report one of # the cycles here. die "Circular dependencies found."; } }

In reply to Re: Partial sort for dependency graph by tilly
in thread Partial sort for dependency graph by throop

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.