You're wrong about the use of $!, at least on unix.

I don't think I am wrong about $! at all, I just follow it's convention according to the documentation. If as you say $! holds the current errno , then as per perlvar, you're clearly wrong about wanting to use it to use it to determine failure of a system call. If i may quote from a section about $! in perlvar.
If used numerically, yields the current value of the C errno variable, + or in other words, if a system or library call fails, it sets this v +ariable. This means that the value of $! is meaningful only immediat +ely after a failure:
The errno variable is not cleared by successful system calls, but it is set by failing ones.

$! is definitely set after a failed system/library call, no doubt about that. The docs say it is not set to zero after success, they do not say it remains unchanged (and that's what you have to watch out for). $! is sometimes cleared after successful calls while also being set in certain other instances. Here's your own code demonstrating both possibilities.

#!/usr/bin/perl -Wl sub doit { $! = undef; open FH, shift or die "open failure: $!\n"; print "After successful open : $!"; 1 while readline FH; print "After successful read : $!"; } doit $0, 5; doit $0, 6; doit $0, undef; __END__ ___output___ ___linux___ After successful open : Inappropriate ioctl for device After successful read : After successful open : Inappropriate ioctl for device After successful read : After successful open : Inappropriate ioctl for device After successful read : $ perl -e 'print $]' 5.008008 $ uname -a Linux cond0 2.6.17-10-386 #2 Fri Oct 13 18:41:40 UTC 2006 i686 GNU/Lin +ux $ cat /etc/issue Ubuntu 6.10 \n \l ___windows___ Name "main::FH" used only once: possible typo at read.pl line 4. After successful open : After successful read : Bad file descriptor After successful open : After successful read : Bad file descriptor After successful open : After successful read : Bad file descriptor $ perl -e "print $]" 5.008006 $ ver Microsoft Windows [Version 5.2.3790] $ type c:\boot.ini | perl -ne "print $1 if /\"(.*)\"/" Windows NT 5.2(3790.srv03.SP1.rtm.050324-1447)
In order to distinguish successful and failing system calls by the use of errno alone

Please don't do that for the sakes of portability and convention, do what everyone else does, use $! only to determine the cause to a failure of a system/library call. If, in doubt, consult the documentation about this variable in perlvar, it is straight-forward and I should imagine it takes precedence over any other documentation that offers any ambiguity.



perl -e '$,=$",$_=(split/\W/,$^X)[y[eval]]]+--$_],print+just,another,split,hack'er

In reply to Re^7: Best way to handle readline errors? by Firefly258
in thread Best way to handle readline errors? by jrw

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.