ikegami's right: that's about as clean as you'll get.

If you want to preserve order, I'd use a hash lookup to determine wether to add the elements instead of using unique; that should be a tiny bit faster but not as good looking. If you don't care about the order, ikegami's solution is better.

my (%country_seen,%state_seen,%city_seen); for my $location (@locations){ next if ($location eq 'HEADING'); my ($country,$state,$city) = split /,/, $location; push @countries, $country unless $country_seen{$country}++; push @states, $state unless $state_seen{$state}++; push @cities, $city unless $city_seen{$city}++; }

In reply to Re: cleaner code .... by Joost
in thread cleaner code .... by tdevil76

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.