Rather than comment on your code, let me first argue against building an SQL command by concatenating strings together -- it makes things really clumsy,

Instead, the approach that I follow is to write the final command that I'm going to submit to the prepare method ..

my $cmd = "INSERT INTO $table ($fields) VALUES ($placeholderList)";
[download]

.. and then work backwards, filling bits in as I go. The sub preamble will be something like this ..

#  Accepts a database handle, a table name, and a hashref
#  of field names and values. Returns on success, otherwise
#  dies.

sub addData
{
  my ( $dbh, $table, $args ) = @_;
[download]

Now it's time to build the pieces leading up to your command ..

  #  Get a comma separated list of the field names ..
  my $fields = join(',', keys %$args);

  #  Get the values into an array ..
  my @values = values %$args;

  #  Get a comma separated list of '?', one for each value
  #  ..
  my $placeholderList = join(',',('?') x @values);
[download]

Then, once the command is built, you do the rest of the stuff with the database ..

  #  Prepare the command and execute it with the array of
  #  values.
  my $sth = $dbh->prepare($cmd);
  $sth->execute(@values) or die $sth->error;

  return 0;     # Success!
[download]

So in the end you have a piece of code that's clean and fairly well documented. Once more, here's the entire thing:

#  Accepts a database handle, a table name, and a hashref
#  of field names and values. Returns on success, otherwise
#  dies.

sub addData
{
  my ( $dbh, $table, $args ) = @_;

  #  Get a comma separated list of the field names ..
  my $fields = join(',', keys %$args);

  #  Get the values into an array ..
  my @values = values %$args;

  #  Get a comma separated list of '?', one for each value ..
  my $placeholderList = join(',',('?') x @values);

  #  Build the entire command ..
  my $cmd = "INSERT INTO $table ($fields) VALUES ($placeholderList)";

  #  Prepare the command and execute it with the array of values.
  my $sth = $dbh->prepare($cmd);
  $sth->execute(@values) or die $sth->error;

  return 0;     # Success!
}
[download]

Way cleaner, no?

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.