Hi texasperl,

If it's not a huge file, you could read it into memory and use map to iterate over all the lines: 

#!/usr/bin/perl -w
use strict;

my $ifile = shift || die "No filename provided\n";
open IFILE, '<', "$ifile"    || die "Couldn't open file: $!";
open OFILE, '+>', 'new-data' || die "Couldn't open outfile: $!";
chomp(my @lines = <IFILE>);
close IFILE;

my @matches = map { /^@.*mail(\d+).*\z/? $1 <= 8? $1: ( ): $_ } @lines
+;

map { print OFILE "$_\n" } @matches;
close OFILE;

[download]

But I don't see anything wrong with the way you did it, except that I would recommend error-checking for the case where a filename isn't passed to the program.

Update:  Fixed to take skip saving anything in the case where the captured pattern isn't <= 8.

Update 2:  Cleaned up syntax further.

s''(q.S:$/9=(T1';s;(..)(..);$..=substr+crypt($1,$2),2,3;eg;print$..$/

In reply to Re: Cleaner way of looping through a file and stripping only certain lines? by liverpole
in thread Cleaner way of looping through a file and stripping only certain lines? by texasperl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.