To add my two cents into this: use fetchrow_hashref

The simple reason is, with an array if you change the SQL statement you need to update the code. This doesn't cause an issue if your only grabbing one line... but what happens when all of a sudden want to get the first name as well so you can say hello afterwards: (note really this code would be best on a multiple reply but in this case it should 'hopefully' be one username only...)

my $p;
my ($userid,$firstname);
my $sth = $dbh->prepare(q{Select user_id,firsname from user where user
+_id = ?});
$sth->execute( $user_name );

while( $p = $sth->fetchrow_hashref )
{
   $userid = $p->{user_id};
   $firstname = $p->{firstname};
}

if(defined $username)
{
   print "Hello $firstname, welcome back!";
}
else
{
   # display an error message, code somewhere else
   loginerror($userid);
}

[download]

--
Even smart people are dumb in most things...

In reply to Re^2: compare two values in perl by Devanchya
in thread compare two values in perl by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.