each() is vulnerable. Like it or not, your re-written version is the standard idiom for looping through a hash's key-value pairs when *anything* outside your control could interfere with an each() call.

foreach my $key ( keys %hash ) {
  my $val = $hash{$key};
  ...
}
[download]

For related info, see the thread Spot the bug, especially the replies by merlyn and ysth.

To improve readability with your long package names, you might do some combination of these refactorings:

• Move the scope of $val back inside the loop.
• Align the long parts of the first two lines:

  foreach my $key ( keys %some::very::long::named::module::foo ) {
    my $val =            $some::very::long::named::module::foo{$key};
  [download]

• Change the if block to next, or pre-filter the keys through grep().
• Use scoped aliases via globs:

  {
    local *foo  = *some::very::long::named::module::foo;
    local *draw = *some::very::long::named::module::drawSomethingPretty;
    foreach my $key ( grep { testconditions($_) } keys %foo ) {
      drawSomethingPretty( $foo{$key} );
    }
  }
  [download]

• Import the identifiers. If such importing is not supported by the module, then submit a request or a patch to the module author.

  use some::very::long::named::module qw( foo drawSomethingPretty );
  foreach my $key ( keys %foo ) {
    next if not testconditions($key);
    drawSomethingPretty( $foo{$key} );
  }
  [download]

  This is the most "correct" way to handle the issue; it is exactly this issue that Exporter is designed to resolve. Work with the author to nail down this part of the module's API. If direct access to %foo is truely part of the API, then it should definitely be available for import. Otherwise, some accessor method should be provided, or the module docs should make clear a proper path to meet the same needs.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.