I'm not so sure. Functions calls are expensive, but are they expensive enough and is there enough data to sort to make the drop in readability worth the gain in speed?

Here's something you can use to benchmark. 

our @unsorted; local *unsorted = $self->teams();
my @sorted;

# Allocate memory up front.
$#sorted = $#unsorted;

# Is it possible to do this faster?
for my $i (0..$#sorted) {
   local *_ = \($unsorted[$i]);
   $sorted[$i] = pack 'C6N', 
      255-($_->get_wins_total()),    # Descending
      255-($_->get_wins_division()), # Descending
      255-($_->get_wins_home()),     # Descending
      255-($_->get_runs_scored()),   # Descending
      $_->get_runs_allowed(),        # Ascending
      $_->get_reg_schedule_id(),     # Ascending
      $i;
}

# In-place lexical sort.
@sorted = sort @sorted;

for my $i (0..$#sorted) {
   $sorted[$i] = $unsorted[unpack('x6N', $sorted[$i])];
}

[download]

In reply to Re^2: Refactor my sort by ikegami
in thread Refactor my sort by Herkum

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.