Well, there are a few places that it could be more efficient.

The very first if in your foreach loop tests for a condition ($netHash{$val} > 1) that's guaranteed by your input loop.

Inside your conditions, you check that the value from $netHash is defined before assignment, but that's also guaranteed by your input loop.

That list of if conditions in the body of foreach all look mutually exclusive, and you're essentially doing "and" with nested conditions. You could rewrite this way: 

# you can get rid of the ($netHash{$val} > 1.0) test
# I only included it to make the example more like yours
   if($netHash{$val} > 1.0 && $netHash{$val} < 1.4) {
         my ($x1, $y1) = ($val,$netHash{$val});
         $capVal_1_Hash{$x1} = $y1;
   }
   elsif($netHash{$val} > 1.4 && $netHash{$val} < 1.9) {
         my ($x2, $y2) = ($val,$netHash{$val});
         $capVal_2_Hash{$x2} = $y2;
   }
   ...
   ...

[download]

That way, you're not checking that a value is between 1.4 and 1.9 after you've already established that it's between 1.0 and 1.4.

I notice you seem to be excluding some values (such as 1.4), and I wonder if that's intentional.

Your printHash might be faster if you don't call keys twice. Like so: 

sub printHash {
    my $href = shift;
    my @href_keys = keys %{$href};
    my $RandKey = $href_keys[int(rand(scalar @href_keys))];
    print "$RandKey $href->{$RandKey}\n";
}

[download]

You seem to have a hundred separate hashes, %capVal_xx_Hash. I'd make those one hash of hashes, but I don't think that will gain you any speed. In that case your $capVal_100_Hash{$x100} = $y100 would be $capVal_Hash{100}{$x100} = $y100, just as an example. Then your repeated calls to printHash at the end could be in a loop: 

foreach my $n ( 1 .. 100 ) {
    printHash( $capVal_hash{$n} );
}

[download]

In that case, you could even factor out the sub printHash and just put it in the loop body, if you wanted. That might be faster (it saves a function call).

If you want to make the code shorter still (y'know, if you're not getting paid by the line), you could put your conditions in an array to loop over. (This is instead of the if ... elsif construct I suggested above.) 

my @range_destination
    = ( [  1.0,   1.4,   1 ],
        [  1.4,   1.9,   2 ],
        ...
        [ 99.2,  99.8,  99 ],
        [100.1, 100.9, 100 ],
       );

# what you call $val is really a KEY,
# but I'll keep your name anyway.
while ( my ( $val, $real_val ) = each %netHash ) {
  CONDITION:
    foreach my $cond_ref ( @range_destination ) {
        my ( $min, $max, $dest ) = @$cond_ref;
        if ( $val > $min && $val < $max ) {
            $capVal_Hash{$dest}{$val} = $real_val;
            last CONDITION;
        }
    }
}

[download]

Using each is more memory efficient. Putting all your ranges in one places makes it easier to see what they are (though I can't tell if that's significant), and it looks like it might be a few hundred lines shorter.

Anyway, hope these suggestions help.

In reply to Re: better way to printing random hash key and its value by kyle
in thread better way to printing random hash key and its value by garbage777

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.