Hi mantra2006,

It's because you're constructing the full pathname of the file with my $file = $File::Find::name;, but that file doesn't exist within the current directory being searched.

If you read the documentation for File::Find, you'll see that you probably want $_ (the current filename only) instead of $File::Find::name (the full pathname).  And if you print out what directory you're in (below with getcwd()), it will make things even more clear: 


use strict;
use warnings;
use File::Path;
use File::Find;
use Cwd;

my $dir="/home/testing";
$dir = "./a";
my @dir = ($dir);
my @srcfiles;
find(\&srcfind, @dir);
sub srcfind {
    ## my $file = $File::Find::name; -- wrong
    my $file = $_;
    printf "TFD> in dir %s, file $file\n", getcwd();
    if (-f $file) {
        if ($file =~ /\.Z$/ or $file =~ /\.zip$/ or $file =~ /\.tar$/ 
+) {
            push @srcfiles, $file;
        }
    }
}
if(@srcfiles){
   print "There are some files\n";
}else{
   print "There are no files \n";
}

__END__

Prints:
TFD> in dir C:/Documents and Settings/liverpole/targetdir, file .
TFD> in dir C:/Documents and Settings/liverpole/targetdir, file a
TFD> in dir C:/Documents and Settings/liverpole/targetdir, file a.Z
TFD> in dir C:/Documents and Settings/liverpole/targetdir, file a.zip
TFD> in dir C:/Documents and Settings/liverpole/targetdir, file b.Z
TFD> in dir C:/Documents and Settings/liverpole/targetdir, file b.zip
TFD> in dir C:/Documents and Settings/liverpole/targetdir, file c.Z
There are some files

[download]

As you can see, I also separated out the conditionals (existence of the file, and regex match) to make things clearer, and easier to debug.

s''(q.S:$/9=(T1';s;(..)(..);$..=substr+crypt($1,$2),2,3;eg;print$..$/

In reply to Re: FindFiles error in condition by liverpole
in thread FindFiles error in condition by mantra2006

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.