I've had to put up with that sort of loop lots of times -- yes, it has a klugy feel to it, but it still seems easier, simpler, clearer, etc, than alternatives, so I just live with it.
Other things can be done in general to streamline your code a little bit -- fewer variables, fewer lines of code, less open/close overhead on the temp file:
open( DAT, '<', 'export.dat' )
or die "Open for read failed on export.dat: $!";
my $tmp; # file handle
while ( <DAT> ) {
next unless ( /\S/ );
if ( /^1/ ) {
if ( defined( $tmp )) {
output_data( $tmp );
}
open( $tmp, '+>', 'export.tmp' ) # open read/write, truncate
+first
or die "Open failed for export.tmp: $!";
}
print $tmp $_;
}
output_data( $tmp );
sub output_data
{
my $fh = shift;
seek( $fh, 0, 0 ); # rewind to start of file
# do stuff with export.tmp contents...
close $fh;
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.