How am I suppose to use your program?

• This clobbers any existing listurls.txt, gives me two copies of the data and puts a useless status message in preferedname.txt:

  linkextractor http://www.blah.com/ > preferedname.txt
  [download]

• This clobbers any existing listurls.txt and puts a useless status message in urls.txt:

  linkextractor http://www.blah.com/ > preferedname.txt & del listurls.t
  +xt
  [download]

• This clobbers any existing listurls.txt and loses any error status message:

  linkextractor http://www.example.com/ > nul & move listurls.txt prefer
  +edname.txt
  [download]

Suggestions:

• Don't say it's OK when it isn't. Use the correct message.
• Don't say it's OK when it is. Only send the URIs to STDOUT.
• Send error messages (incl non 200 status messages) to STDERR.
• Convert the URIs to absolute URIs.
• Remove duplicate URIs.
• Replace my $url = <@ARGV>; with my ($url) = @ARGV;.
• The domain www.example.com (among others) was set aside for examples. It's better to use that than www.blah.com, a real live domain.

Suggestions applied:

use strict;
use warnings;

use List::MoreUtils qw( uniq );
use WWW::Mechanize  qw( );

# usage: linkextractor http://www.blah.com/ > listurls.txt
my ($url) = @ARGV;

my $mech = WWW::Mechanize->new();
my $response = $mech->get($url);
$response->is_success()
   or die($response->status_line() . "\n");

print map { "$_\n" }
      sort { $a cmp $b }
      uniq
      map { $_->url_abs() }
      $mech->links();
[download]

Update: At first, I didn't realize it was outputing to STDOUT in addition to listurls.txt. I recommended that the output should be sent to STDOUT. This is a rewrite.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.